[GitHub] [carbondata] ravipesala commented on a change in pull request #3237: [CARBONDATA-3399] Implement excutor id based distribution for indexserver

[GitBox]

ravipesala commented on a change in pull request #3237: [CARBONDATA-3399] Implement excutor id based distribution for indexserver
URL: https://github.com/apache/carbondata/pull/3237#discussion_r287936661
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/indexserver/DistributedRDDUtils.scala
 ##########
 @@ -47,10 +46,24 @@ object DistributedRDDUtils {
                                               .getDistributable.getSegment.getIndexSize)
     val executorCache = DistributedRDDUtils.executorToCacheSizeMapping
     // check if any executor is dead.
-    val invalidExecutors = executorCache.keySet().asScala.diff(executorsList)
-    if (invalidExecutors.nonEmpty) {
+    val invalidHosts = executorCache.keySet().asScala.diff(executorsList.keySet)
 
 Review comment:
   There can be a chance of executor down also, not just complete machine down.  It is better to get the invalid executors.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services