[GitHub] [carbondata] ravipesala commented on a change in pull request #3245: [CARBONDATA-3398] Handled show cache for index server and MV

[GitBox]

ravipesala commented on a change in pull request #3245: [CARBONDATA-3398] Handled show cache for index server and MV
URL: https://github.com/apache/carbondata/pull/3245#discussion_r290997482
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/carbondata/indexserver/DistributedShowCacheRDD.scala
 ##########
 @@ -43,15 +50,23 @@ class DistributedShowCacheRDD(@transient private val ss: SparkSession, tableName
 
   override def internalCompute(split: Partition, context: TaskContext): Iterator[String] = {
     val dataMaps = DataMapStoreManager.getInstance().getAllDataMaps.asScala
+    val tableList = tableName.split(",").map(_.replace("-", "_"))
     val iterator = dataMaps.collect {
-      case (table, tableDataMaps) if table.isEmpty ||
-                                     (tableName.nonEmpty && tableName.equalsIgnoreCase(table)) =>
+      case (table, tableDataMaps) if tableName.isEmpty || tableList.contains(table) =>
         val sizeAndIndexLengths = tableDataMaps.asScala
-          .map(_.getBlockletDetailsFetcher.getCacheSize)
-        // return tableName_indexFileLength_indexCachesize for each executor.
-        sizeAndIndexLengths.map {
-          x => s"$table:$x"
-        }
+          .map { dataMap =>
+            // if datamap name is null then it means that the TableDataMap is of BlockletDatamap
+            // type.
 
 Review comment:
   This statement seems not valid, update the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services