[GitHub] [carbondata] ravipesala commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's

[GitBox]

ravipesala commented on a change in pull request #3264: [CARBONDATA-3418] Inherit Column Compressor Property from parent table to its child table's
URL: https://github.com/apache/carbondata/pull/3264#discussion_r291927577
 
 

 ##########
 File path: docs/ddl-of-carbondata.md
 ##########
 @@ -811,6 +811,7 @@ Users can specify which columns to include and exclude for local dictionary gene
        new SORT_COLUMNS.  
       
        UNSET is not supported, but it can set SORT_COLUMNS to empty string instead of using UNSET.
+       NOTE: SORT_SCOPE should not be NO_SORT, when set SORT_COLUMNS to empty
 
 Review comment:
   when `SORT_COLUMNS` is empty, there is no significance to `SORT_SCOPE`. By default, it becomes `NO_SORT` always. So if we need to add validation we should not allow `SORT_SCOPE` at all in case of empty SORT_COLUMNS

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services