[GitHub] [carbondata] ravipesala commented on a change in pull request #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object

[GitBox]

ravipesala commented on a change in pull request #3270: [CARBONDATA-3422] fix missing complex dimensions when prepare the data from raw object
URL: https://github.com/apache/carbondata/pull/3270#discussion_r295088930
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/merger/CompactionResultSortProcessor.java
 ##########
 @@ -268,7 +268,9 @@ private void processResult(List<RawResultIterator> resultIteratorList) throws Ex
    * @return
    */
   private Object[] prepareStreamingRowObjectForSorting(Object[] row) {
-    List<CarbonDimension> dimensions = segmentProperties.getDimensions();
+    List<CarbonDimension> dimensions = new ArrayList<>();
 
 Review comment:
   Don't create a list and add here, every row it creates list object unnecessarily. Please create at the class level and use it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services