[GitHub] [carbondata] ravipesala commented on a change in pull request #3295: [CARBONDATA-3373] Fixed measure column filter perf

[GitBox]

ravipesala commented on a change in pull request #3295: [CARBONDATA-3373] Fixed measure column filter perf
URL: https://github.com/apache/carbondata/pull/3295#discussion_r295149279
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/filter/executer/IncludeFilterExecuterImpl.java
 ##########
 @@ -631,4 +628,99 @@ public void readColumnChunks(RawBlockletColumnChunks rawBlockletColumnChunks) th
       }
     }
   }
+
+  /**
+   * Below method will be used to execute measure filter based on data type
+   * This is done to avoid conversion of primitive type to primitive object
+   * as it may cause lots of gc when number of record is high and will impact performance
+   * @param page
+   * @param numberOfRows
+   * @param bitSet
+   * @param nullBitset
+   * @param measureColumnExecuterFilterInfo
+   * @param dataType
+   */
+  private void executeIncludeFilterMeasure(ColumnPage page, int numberOfRows, BitSet bitSet,
 
 Review comment:
   Its almost a duplicate method to `executeExcludeFilterForMeasure`. Better pass a small wrapper object of Bitset to this method to flip/set the bit and use the same method for both of them.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services