[GitHub] [carbondata] ravipesala commented on a change in pull request #3298: [CARBONDATA-3444]Fix MV query failure when projection has cast expression with alias

[GitBox]

ravipesala commented on a change in pull request #3298: [CARBONDATA-3444]Fix MV query failure when projection has cast expression with alias
URL: https://github.com/apache/carbondata/pull/3298#discussion_r296103138
 
 

 ##########
 File path: datamap/mv/core/src/main/scala/org/apache/carbondata/mv/rewrite/DefaultMatchMaker.scala
 ##########
 @@ -121,8 +121,10 @@ object SelectSelectNoChildDelta extends DefaultMatchPattern with PredicateHelper
     } else if (subsumee.asInstanceOf[Select].outputList.contains(exprE)) {
       exprE match {
         case a@Alias(_, _) =>
-          exprListR.exists(a1 => a1.isInstanceOf[Alias] &&
-                                 a1.asInstanceOf[Alias].child.semanticEquals(a.child)) ||
+          exprListR
+            .exists(a1 => a1.isInstanceOf[Alias] &&
+                          a.name.equalsIgnoreCase(a1.asInstanceOf[Alias].name) &&
 
 Review comment:
   when semantic returns true then why we still need to check equalsignorecase

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services