[GitHub] [carbondata] ravipesala commented on a change in pull request #3306: [CARBONDATA-3452] Fix select query failure when substring on dictionary column with join

[GitBox]

ravipesala commented on a change in pull request #3306: [CARBONDATA-3452] Fix select query failure when substring on dictionary column with join
URL: https://github.com/apache/carbondata/pull/3306#discussion_r298147390
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/optimizer/CarbonLateDecodeRule.scala
 ##########
 @@ -697,12 +697,19 @@ class CarbonLateDecodeRule extends Rule[LogicalPlan] with PredicateHelper {
         marker.pushBinaryMarker(allAttrsNotDecode)
         u
       case p: Project if relations.nonEmpty =>
-        val prExps = p.projectList.map { prExp =>
-          prExp.transform {
-            case attr: AttributeReference =>
-              updateDataType(attr, attrMap, allAttrsNotDecode, aliasMap)
-          }
-        }.asInstanceOf[Seq[NamedExpression]]
+        val prExps = if (p.projectList.toString().contains("substring")) {
 
 Review comment:
   It is sort of a hack, what if some other udf is used or the column name contains the substring part.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services