[GitHub] [carbondata] ravipesala commented on a change in pull request #3322: [WIP]Fixed NPE in Concurrent query

[GitBox]

ravipesala commented on a change in pull request #3322: [WIP]Fixed NPE in Concurrent query
URL: https://github.com/apache/carbondata/pull/3322#discussion_r302136741
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/datastore/block/SegmentPropertiesAndSchemaHolder.java
 ##########
 @@ -204,6 +204,9 @@ public void invalidate(AbsoluteTableIdentifier absoluteTableIdentifier) {
           .getTableUniqueName()
           .equals(absoluteTableIdentifier.getCarbonTableIdentifier().getTableUniqueName())) {
         SegmentIdAndSegmentPropertiesIndexWrapper value = entry.getValue();
+        synchronized (deleteIndexToDeleteTimestampMapping) {
 
 Review comment:
   I guess in this method also we might need to add to deleteMap and check the timetolive like it is done in the below method

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services