[GitHub] [carbondata] ravipesala commented on a change in pull request #3374: [CARBONDATA-3496] Maintain the list of TableDataMap based on tableId instead of tableName

[GitBox]

ravipesala commented on a change in pull request #3374: [CARBONDATA-3496] Maintain the list of TableDataMap based on tableId instead of tableName
URL: https://github.com/apache/carbondata/pull/3374#discussion_r334354520
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/SessionParams.java
 ##########
 @@ -218,15 +217,7 @@ private boolean validateKeyValue(String key, String value) throws InvalidConfigu
         } else if (key.startsWith(CarbonCommonConstantsInternal.QUERY_ON_PRE_AGG_STREAMING)) {
           isValid = true;
         } else if (key.startsWith(CarbonCommonConstants.CARBON_DATAMAP_VISIBLE)) {
-          String[] keyArray = key.split("\\.");
-          isValid = DataMapStoreManager.getInstance().isDataMapExist(
-              keyArray[keyArray.length - 3],
-              keyArray[keyArray.length - 2],
-              keyArray[keyArray.length - 1]);
-          if (!isValid) {
-            throw new InvalidConfigurationException(
-                String.format("Invalid configuration of %s, datamap does not exist", key));
-          }
+          isValid = true;
 
 Review comment:
   Why this validation is not needed? no need to check `isDataMapExist `?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services