ravipesala commented on a change in pull request #3426: [CARBONDATA-3560] Fixed issues for Add Segment
URL:
https://github.com/apache/carbondata/pull/3426#discussion_r341929509
##########
File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonAddLoadCommand.scala
##########
@@ -92,6 +92,23 @@ case class CarbonAddLoadCommand(
val segmentPath = options.getOrElse(
"path", throw new UnsupportedOperationException("PATH is manadatory"))
+ val allSegments = SegmentStatusManager.readLoadMetadata(carbonTable.getMetadataPath)
+
+ // If a path is already added then we should block the adding of the same path again.
+ allSegments.exists { a =>
+ a.getPath != null && a.getPath.equalsIgnoreCase(segmentPath)
+ throw new AnalysisException(s"Cannot add the segment. This path is already in use by " +
+ s"another segment.")
+ }
+
+ val format = options.getOrElse("format", "carbondata")
+ val isCarbonFormat = format.equalsIgnoreCase("carbondata") || format.equalsIgnoreCase("carbon")
+
+ // If in the given location no carbon files are found then we can throw an exception
+ if (isCarbonFormat && SegmentFileStore.getListOfCarbonIndexFiles(segmentPath).isEmpty) {
Review comment:
I think this validation should come from SparkFiileFormat, so ideally there should not be any changes in this class for format level validation. Better move it to format level
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
