ravipesala commented on a change in pull request #3427: [CARBONDATA-3562] Fix for SDK filter queries not working when schema is given explicitly while Add Segment
URL:
https://github.com/apache/carbondata/pull/3427#discussion_r342426514
##########
File path: core/src/main/java/org/apache/carbondata/core/scan/executor/util/RestructureUtil.java
##########
@@ -200,8 +207,14 @@ private static boolean isColumnMatchesStruct(CarbonColumn tableColumn, CarbonCol
}
carbonDimension = CarbonTable.getCarbonDimension(tempColName.toString(), parentDimension);
if (carbonDimension != null) {
+ // In case of SDK the columnId and columnName is same and this check will ensure for
+ // all the child columns that the table column name is equal to query column name and
+ // table columnId is equal to table columnName
if (carbonDimension.getColumnSchema().getColumnUniqueId()
- .equalsIgnoreCase(queryColumn.getColumnId())) {
+ .equalsIgnoreCase(queryColumn.getColumnId()) || (
+ carbonDimension.getColumnSchema().getColumnUniqueId()
Review comment:
Why there is a diff of condition check for dimension and measure? Here we compare with ColumnUniqueId but other places are not
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
