[GitHub] [carbondata] ravipesala commented on a change in pull request #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list

[GitBox]

ravipesala commented on a change in pull request #3481: [CARBONDATA-3548]Geospatial Support： add hash id create，query condition analyze and generate hash id list
URL: https://github.com/apache/carbondata/pull/3481#discussion_r351969161
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/geo/GeoHashImpl.java
 ##########
 @@ -31,10 +31,73 @@
  * GeoHash default implementation
  */
 public class GeoHashImpl extends CustomIndex<List<Long[]>> {
+  // 角度转弧度的转换因子
+  private static final double CONVERT_FACTOR = 180.0;
+  // 地球半径
+  private static final double EARTH_RADIUS = 6371004.0;
+
+  private static final String GEOHASH = "geohash";
+  // 赤道经度1度或者纬度1度对应的地理空间距离
 
 Review comment:
   please translate all chinese comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services