[GitHub] [carbondata] ravipesala opened a new pull request #3704: [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)

[GitBox]

ravipesala opened a new pull request #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704
 
 
   There is a commit missed during PR merge of https://github.com/apache/carbondata/pull/3483 
   
   ### Why is this PR needed?
   
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704#issuecomment-612070367
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/996/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704#issuecomment-612084745
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2708/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704#issuecomment-612790724
 
 
   @jackylk : please check and merge.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat edited a comment on issue #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704#issuecomment-612790724
 
 
   @jackylk : please check and merge as you already reviewed #3483.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704#issuecomment-615115922
 
 
   LGTM.
   
   It was already reviewed in #3704 and changes are done as per latest insert flow now.
   
   Instead of direct call to writer, it is better to use insert flow to write data.
   
   so merging it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat edited a comment on issue #3704:  [CARBONDATA-3597] Missed commit from PR-3483 (SCD2)
URL: https://github.com/apache/carbondata/pull/3704#issuecomment-615115922
 
 
   LGTM.
   
   It was already reviewed in #3483 and changes are done as per latest insert flow now.
   
   Instead of direct call to writer, it is better to use insert flow to write data.
   
   so merging it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services