[GitHub] [carbondata] shenh062326 commented on a change in pull request #3476: [CARBONDATA-3593] Fix TOTAL_BLOCKLET_NUM not right when blocklet filt…

[GitBox]

shenh062326 commented on a change in pull request #3476: [CARBONDATA-3593] Fix TOTAL_BLOCKLET_NUM not right when blocklet filt…
URL: https://github.com/apache/carbondata/pull/3476#discussion_r351995025
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
 ##########
 @@ -113,6 +113,10 @@ public boolean isScanRequired(DataRefNode dataBlock) {
         .get(QueryStatisticsConstants.TOTAL_PAGE_SCANNED);
     totalPagesScanned.addCountStatistic(QueryStatisticsConstants.TOTAL_PAGE_SCANNED,
         totalPagesScanned.getCount() + dataBlock.numberOfPages());
+    QueryStatistic totalBlockletStatistic = queryStatisticsModel.getStatisticsTypeAndObjMap()
 
 Review comment:
   I think "total_blocklets" should be the total of all blocklet, valid_blocklets should be the filtered blocklet. Just like "total_pages", the total_pages is all the pages, not filtered pages.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services