shenh062326 commented on a change in pull request #3476: [CARBONDATA-3593] Fix TOTAL_BLOCKLET_NUM not right when blocklet filt…
URL:
https://github.com/apache/carbondata/pull/3476#discussion_r352273734
##########
File path: core/src/main/java/org/apache/carbondata/core/scan/scanner/impl/BlockletFilterScanner.java
##########
@@ -113,6 +113,10 @@ public boolean isScanRequired(DataRefNode dataBlock) {
.get(QueryStatisticsConstants.TOTAL_PAGE_SCANNED);
totalPagesScanned.addCountStatistic(QueryStatisticsConstants.TOTAL_PAGE_SCANNED,
totalPagesScanned.getCount() + dataBlock.numberOfPages());
+ QueryStatistic totalBlockletStatistic = queryStatisticsModel.getStatisticsTypeAndObjMap()
Review comment:
The current blocklet statistics include total_blocklets, valid_blocklets, but the page statistics include total_pages, scanned_pages, and valid_pages. Is it possible to add a scanned_blocklets? Finally, total_blocklets is similar to total_pages, valid_blocklets is similar to valid_pages, and scanned_blocklets is similar to scanned_pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
