[GitHub] [carbondata] shivamasn commented on a change in pull request #3140: [CARBONDATA-3307] Fix Performance Issue in No Sort

[GitBox]

shivamasn commented on a change in pull request #3140: [CARBONDATA-3307] Fix Performance Issue in No Sort
URL: https://github.com/apache/carbondata/pull/3140#discussion_r263241591
 
 

 ##########
 File path: processing/src/main/java/org/apache/carbondata/processing/store/CarbonFactDataHandlerColumnar.java
 ##########
 @@ -195,7 +195,7 @@ public void initialise() throws CarbonDataWriterException {
    * @param row
    * @throws CarbonDataWriterException
    */
-  public void addDataToStore(CarbonRow row) throws CarbonDataWriterException {
+  public synchronized void addDataToStore(CarbonRow row) throws CarbonDataWriterException {
 
 Review comment:
   @qiuchenjian After changing "addaDataToStore" as synchronized, performance is increased. Earlier it was taking 2.77 hrs for loading 3.5 billion records. After the fix, it is taking 1.87 hrs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services