[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3669: Added pre-priming check in the Spark job description page

[GitBox]

vikramahuja1001 opened a new pull request #3669: Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669
 
 
    ### Why is this PR needed?
    Added pre-priming check in the Spark job description page
   
    ### What changes were proposed in this PR?
   
       
    ### Does this PR introduce any user interface change?
    - No
    - Yes. (please explain the change and update document)
   
    ### Is any new testcase added?
    - No
    - Yes
   
       
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [WIP] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-598708264
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2456/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [WIP] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-598730776
 
 
   Build Success with Spark 2.4.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.4/748/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-601131892
 
 
   @vikramahuja1001 Please update the PR description, Changes Added

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

Indhumathi27 commented on a change in pull request #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#discussion_r394967281
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala
 ##########
 @@ -131,8 +131,15 @@ object IndexServer extends ServerInterface {
       lazy val getCountTask = {
         if (!request.isFallbackJob) {
           sparkSession.sparkContext.setLocalProperty("spark.jobGroup.id", request.getTaskGroupId)
-          sparkSession.sparkContext
-            .setLocalProperty("spark.job.description", request.getTaskGroupDesc)
+          if (!request.ifAsyncCall()) {
 
 Review comment:
   Can simplify the code like below:
             val taskGroupDesc = if (!request.ifAsyncCall()) {
               request.getTaskGroupDesc
             } else {
               "PrePriming Job Fired for table: " + request.getCarbonTable.getDatabaseName +
               CarbonCommonConstants.POINT + request.getCarbonTable.getTableName
             }
             sparkSession.sparkContext.setLocalProperty("spark.job.description", taskGroupDesc)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-607045224
 
 
   @vikramahuja1001 Please fix comments

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

vikramahuja1001 commented on a change in pull request #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#discussion_r403817286
 
 

 ##########
 File path: integration/spark/src/main/scala/org/apache/carbondata/indexserver/IndexServer.scala
 ##########
 @@ -131,8 +131,15 @@ object IndexServer extends ServerInterface {
       lazy val getCountTask = {
         if (!request.isFallbackJob) {
           sparkSession.sparkContext.setLocalProperty("spark.jobGroup.id", request.getTaskGroupId)
-          sparkSession.sparkContext
-            .setLocalProperty("spark.job.description", request.getTaskGroupDesc)
+          if (!request.ifAsyncCall()) {
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609585667
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/932/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609591954
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2642/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

vikramahuja1001 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609597461
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609669854
 
 
   Build Failed  with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/937/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609677985
 
 
   Build Failed  with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2647/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609682404
 
 
   @vikramahuja1001 Please fix the build
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

vikramahuja1001 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-609692072
 
 
   @kunal642 , the build is completing. There seems to be some issue with jenkins.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-610801146
 
 
   retest this please

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-610872012
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/967/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-610879525
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2680/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

kunal642 commented on issue #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669#issuecomment-610882710
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3669: [CARBONDATA-3743] Added pre-priming check in the Spark job description page
URL: https://github.com/apache/carbondata/pull/3669
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services