[GitHub] [carbondata] vikramahuja1001 opened a new pull request #3679: [WIP]: Update_delete_issue

[GitBox]

CarbonDataQA1 commented on issue #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#issuecomment-609603497
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2645/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#discussion_r407363310
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
 ##########
 @@ -168,7 +169,7 @@ public void serializeData(DataOutput out, Map<String, Short> uniqueLocation, boo
       throws IOException {
     super.write(out);
     if (isCountJob) {
-      out.writeLong(inputSplit.getRowCount());
+      out.writeLong(inputSplit.getIndexRow().getInt(BlockletIndexRowIndexes.ROW_COUNT_INDEX));
 
 Review comment:
   Please add below comment on separate commit, I will merge this.
   
   In CarbonInputSplit, getDetailInfo() is a lazy call. we want to avoid this during count(*). As rowCount is filled inside getDetailInfo(). In count(*) case we may not have proper row count. So, always take row count from indexRow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on a change in pull request #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#discussion_r407363310
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
 ##########
 @@ -168,7 +169,7 @@ public void serializeData(DataOutput out, Map<String, Short> uniqueLocation, boo
       throws IOException {
     super.write(out);
     if (isCountJob) {
-      out.writeLong(inputSplit.getRowCount());
+      out.writeLong(inputSplit.getIndexRow().getInt(BlockletIndexRowIndexes.ROW_COUNT_INDEX));
 
 Review comment:
   Please add below comment on separate commit, I will merge this.
   
   In CarbonInputSplit, getDetailInfo() is a lazy call. we want to avoid this during countStar query. As rowCount is filled inside getDetailInfo(). In countStar case we may not have proper row count. So, always take row count from indexRow.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

vikramahuja1001 commented on a change in pull request #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#discussion_r407448723
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/ExtendedBlocklet.java
 ##########
 @@ -168,7 +169,7 @@ public void serializeData(DataOutput out, Map<String, Short> uniqueLocation, boo
       throws IOException {
     super.write(out);
     if (isCountJob) {
-      out.writeLong(inputSplit.getRowCount());
+      out.writeLong(inputSplit.getIndexRow().getInt(BlockletIndexRowIndexes.ROW_COUNT_INDEX));
 
 Review comment:
   done

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#issuecomment-612921854
 
 
   Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12545/job/ApacheCarbon_PR_Builder_2.4.5/1014/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

CarbonDataQA1 commented on issue #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#issuecomment-612929101
 
 
   Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12545/job/ApacheCarbonPRBuilder2.3/2726/
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

ajantha-bhat commented on issue #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679#issuecomment-612957103
 
 
   LGTM

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services

[GitBox]

asfgit closed pull request #3679: [CARBONDATA-3751]:  Segments are not Marked for delete if everything is deleted in a segment with index server enabled
URL: https://github.com/apache/carbondata/pull/3679
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services