[GitHub] [carbondata] xubo245 commented on a change in pull request #3173: [WIP][CARBONDATA-3336] Support Binary Data Type

[GitBox]

xubo245 commented on a change in pull request #3173:  [WIP][CARBONDATA-3336] Support Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r273417614
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonWriterBuilder.java
 ##########
 @@ -445,6 +449,21 @@ public CarbonWriterBuilder withBlockletSize(int blockletSize) {
     return this;
   }
 
+  /**
+   * To set the blocklet size of CarbonData file
+   *
+   * @param pageSizeInMb is page size in MB
+   *                     default value is 1 MB.
+   * @return updated CarbonWriterBuilder
+   */
+  public CarbonWriterBuilder withPageSizeInMb(int pageSizeInMb) {
+    if (pageSizeInMb < 1 || pageSizeInMb > 1755) {
 
 Review comment:
   this code is from PR2814, this PR dependency on it. it will be removed after PR2814 is merged

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services