[GitHub] [carbondata] xubo245 commented on a change in pull request #3173: [WIP][CARBONDATA-3336] Support Binary Data Type

[GitBox]

xubo245 commented on a change in pull request #3173:  [WIP][CARBONDATA-3336] Support Binary Data Type
URL: https://github.com/apache/carbondata/pull/3173#discussion_r273419762
 
 

 ##########
 File path: store/sdk/src/main/java/org/apache/carbondata/sdk/file/CarbonReaderBuilder.java
 ##########
 @@ -131,21 +203,66 @@ public CarbonReaderBuilder withBatch(int batch) {
   public CarbonReaderBuilder withHadoopConf(String key, String value) {
     if (this.hadoopConf == null) {
       this.hadoopConf = new Configuration();
-
     }
     this.hadoopConf.set(key, value);
     return this;
   }
 
   /**
    * Configure Row Record Reader for reading.
-   *
    */
   public CarbonReaderBuilder withRowRecordReader() {
     this.useVectorReader = false;
     return this;
   }
 
+  public InputSplit[] getSplits() throws IOException {
+    if (hadoopConf == null) {
+      hadoopConf = FileFactory.getConfiguration();
+    }
+    CarbonTable table;
+    // now always infer schema. TODO:Refactor in next version.
+    table = CarbonTable.buildTable(tablePath, tableName, hadoopConf, false);
+    final CarbonFileInputFormat format = new CarbonFileInputFormat();
+    final Job job = new Job(hadoopConf);
+    Map<String, String> tableProperties = table.getTableInfo().getFactTable().getTableProperties();
+    tableProperties.put(CarbonCommonConstants.CACHE_LEVEL, "BLOCKLET");
 
 Review comment:
   no need this code, removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services