[GitHub] [carbondata] xubo245 commented on a change in pull request #3181: [CARBONDATA-3356] Support decimal for json schema and Provide better exception for users to solve problem when carbonData DataSource read SDK files with varchar

[GitBox]

xubo245 commented on a change in pull request #3181: [CARBONDATA-3356]  Support decimal for json schema and Provide better exception for users to solve problem  when carbonData DataSource read SDK files with varchar
URL: https://github.com/apache/carbondata/pull/3181#discussion_r292863311
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/BlockletDataMapUtil.java
 ##########
 @@ -264,6 +264,16 @@ public static boolean isSameColumnAndDifferentDatatypeInSchema(
             .equalsIgnoreCase(tableColumnList.get(i).getColumnName()) && !indexFileColumnList.get(j)
             .getDataType().getName()
             .equalsIgnoreCase(tableColumnList.get(i).getDataType().getName())) {
+          if ("varchar".equalsIgnoreCase(indexFileColumnList.get(j).getDataType().getName()) &&
+              "string".equalsIgnoreCase(tableColumnList.get(i).getDataType().getName())) {
+            throw new RuntimeException("Datatype of the Column "
 
 Review comment:
   org.apache.hadoop.mapreduce.RecordReader#initialize only support throw IOException, InterruptedException;, so we should convert InvalidConfigurationException
    to IOException or InterruptedException in org.apache.carbondata.hadoop.CarbonRecordReader#initialize, org.apache.carbondata.hadoop.util.CarbonVectorizedRecordReader#initialize
   
   is it ok?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services