[GitHub] [carbondata] xubo245 commented on a change in pull request #3194: [CARBONDATA-3363] SDK supports read carbon data by given file lists, file or folder

[GitBox]

xubo245 commented on a change in pull request #3194: [CARBONDATA-3363] SDK supports read carbon data by given file lists, file or folder
URL: https://github.com/apache/carbondata/pull/3194#discussion_r285558010
 
 

 ##########
 File path: hadoop/src/main/java/org/apache/carbondata/hadoop/api/CarbonFileInputFormat.java
 ##########
 @@ -208,6 +215,18 @@ public CarbonTable getOrCreateCarbonTable(Configuration configuration) throws IO
     return carbonFiles;
   }
 
+  private List<CarbonFile> getAllCarbonDataFiles(List fileLists) {
+    List<CarbonFile> carbonFiles = new LinkedList<CarbonFile>();
 
 Review comment:
   has add operation for list:
   
   ```
     public CarbonReaderBuilder withFileLists(List fileLists) {
       if (null == this.fileLists) {
         this.fileLists = fileLists;
       } else {
         this.fileLists.addAll(fileLists);
       }
       return this;
     }
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services