[GitHub] [carbondata] xubo245 commented on a change in pull request #3245: [CARBONDATA-3398] Handled show cache for index server and MV

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] xubo245 commented on a change in pull request #3245: [CARBONDATA-3398] Handled show cache for index server and MV

GitBox
xubo245 commented on a change in pull request #3245: [CARBONDATA-3398] Handled show cache for index server and MV
URL: https://github.com/apache/carbondata/pull/3245#discussion_r294346162
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockletDataMapFactory.java
 ##########
 @@ -302,14 +302,18 @@ public synchronized void clear() {
     }
   }
 
-  @Override public String getCacheSize() throws IOException {
+  @Override public String getCacheSize() {
 
 Review comment:
   Please optimize this line to two lines:
   ```
     @Override
     public String getCacheSize() {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services