[GitHub] [carbondata] xubo245 commented on a change in pull request #3251: [CARBONDATA-3408] CarbonSession partition support binary data type

[GitBox]

xubo245 commented on a change in pull request #3251: [CARBONDATA-3408] CarbonSession partition support binary data type
URL: https://github.com/apache/carbondata/pull/3251#discussion_r291875476
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/util/DataTypeUtil.java
 ##########
 @@ -478,7 +478,12 @@ public static Object getDataDataTypeForNoDictionaryColumn(String dimensionValue,
     } else if (actualDataType == DataTypes.TIMESTAMP) {
       return ByteUtil.toXorBytes((Long) dimensionValue);
     } else if (actualDataType == DataTypes.BINARY) {
-      return (byte[]) dimensionValue;
+      if (dimensionValue instanceof String) {
+        return ((String) dimensionValue).getBytes(
 
 Review comment:
   no need to decode in here, only convert string to byte[]

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services