[GitHub] [carbondata] xubo245 commented on a change in pull request #3442: [HOTFIX] Remove unnecessary Map object in CarbonTable

[GitBox]

xubo245 commented on a change in pull request #3442: [HOTFIX] Remove unnecessary Map object in CarbonTable
URL: https://github.com/apache/carbondata/pull/3442#discussion_r347118825
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
 ##########
 @@ -86,31 +85,26 @@
    */
   private TableInfo tableInfo;
   /**
-   * TableName, Dimensions list. This map will contain allDimensions which are visible
+   * Dimensions list. This map will contain allDimensions which are visible
    */
-  private Map<String, List<CarbonDimension>> tableDimensionsMap;
+  private List<CarbonDimension> visibleDimensions;
 
   /**
    * list of all the allDimensions
    */
   private List<CarbonDimension> allDimensions;
 
-  private Map<String, List<CarbonColumn>> createOrderColumn;
-
-  /**
-   * TableName, Dimensions and children allDimensions list
-   */
-  private Map<String, List<CarbonDimension>> tablePrimitiveDimensionsMap;
+  private List<CarbonColumn> createOrderColumn;
 
   /**
    * table allMeasures list.
 
 Review comment:
   Can you optimize the description?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services