[GitHub] [carbondata] xubo245 commented on a change in pull request #3442: [HOTFIX] Remove unnecessary Map object in CarbonTable

[GitBox]

xubo245 commented on a change in pull request #3442: [HOTFIX] Remove unnecessary Map object in CarbonTable
URL: https://github.com/apache/carbondata/pull/3442#discussion_r347118979
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/CarbonTable.java
 ##########
 @@ -642,74 +621,34 @@ public long getTableLastUpdatedTime() {
   }
 
   /**
-   * to get the number of dimension present in the table
-   *
-   * @param tableName
-   * @return number of dimension present the table
-   */
-  public int getNumberOfDimensions(String tableName) {
-    return tableDimensionsMap.get(tableName).size();
-  }
-
-  /**
-   * to get the number of allMeasures present in the table
-   *
-   * @param tableName
-   * @return number of allMeasures present the table
-   */
-  public int getNumberOfMeasures(String tableName) {
-    return tableMeasuresMap.get(tableName).size();
-  }
-
-  /**
-   * to get the all dimension of a table
-   *
-   * @param tableName
-   * @return all dimension of a table
-   */
-  public List<CarbonDimension> getDimensionByTableName(String tableName) {
-    return tableDimensionsMap.get(tableName);
-  }
-
-  /**
-   * to get the all measure of a table
-   *
-   * @param tableName
-   * @return all measure of a table
-   */
-  public List<CarbonMeasure> getMeasureByTableName(String tableName) {
-    return tableMeasuresMap.get(tableName);
-  }
-
-  /**
-   * Return all dimensions of the table
+   * Return all visible dimensions of the table
    */
   public List<CarbonDimension> getDimensions() {
 
 Review comment:
   Why didn't use  getVisibleDimensions instead of getDimensions?  There is getAllDimensions, it's confused

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services