[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3153: [CARBONDATA-3319][TestCase]Added condition to check if datamap exist or not before caching

[GitBox]

xuchuanyin commented on a change in pull request #3153: [CARBONDATA-3319][TestCase]Added condition to check if datamap exist or not before caching
URL: https://github.com/apache/carbondata/pull/3153#discussion_r267755221
 
 

 ##########
 File path: integration/spark-datasource/src/test/scala/org/apache/spark/sql/carbondata/datasource/TestCreateTableUsingSparkCarbonFileFormat.scala
 ##########
 @@ -438,9 +438,11 @@ class TestCreateTableUsingSparkCarbonFileFormat extends FunSuite with BeforeAndA
   private def clearDataMapCache(): Unit = {
     if (!spark.sparkContext.version.startsWith("2.1")) {
       val mapSize = DataMapStoreManager.getInstance().getAllDataMaps.size()
-      DataMapStoreManager.getInstance()
-        .clearDataMaps(AbsoluteTableIdentifier.from(writerPath))
-      assert(mapSize > DataMapStoreManager.getInstance().getAllDataMaps.size())
+      if (mapSize > 0) {
 
 Review comment:
   Why need this check?
   I think there may be some hidden problems in other tests that lead us uncertain about whether this value is 0 or not. As a result, current modification will hide those problems, which means this modification is **not proper** in my opinion.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services