[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3156: [CARBONDATA-3320]fix number of partitions issue in describe formatted

[GitBox]

xuchuanyin commented on a change in pull request #3156: [CARBONDATA-3320]fix number of partitions issue in describe formatted
URL: https://github.com/apache/carbondata/pull/3156#discussion_r267748280
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/metadata/SegmentFileStore.java
 ##########
 @@ -861,6 +858,18 @@ private static void deletePhysicalPartition(List<PartitionSpec> partitionSpecs,
     }
   }
 
+  /**
+   * This method deletes the directories recursively if there are no files under that folder
 
 Review comment:
   This comment does not describe the function precisely.
   As a matter of fact, you are trying to delete the parent directory too, but the comment here does not point that out.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services