[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3183: [CARBONDATA-3349] Show sort_columns for each segment

[GitBox]

xuchuanyin commented on a change in pull request #3183: [CARBONDATA-3349] Show sort_columns for each segment
URL: https://github.com/apache/carbondata/pull/3183#discussion_r278952582
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/management/CarbonShowLoadsCommand.scala
 ##########
 @@ -52,7 +54,9 @@ case class CarbonShowLoadsCommand(
         AttributeReference("Merged To", StringType, nullable = false)(),
         AttributeReference("File Format", StringType, nullable = false)(),
         AttributeReference("Data Size", StringType, nullable = false)(),
-        AttributeReference("Index Size", StringType, nullable = false)())
+        AttributeReference("Index Size", StringType, nullable = false)(),
+        AttributeReference("Is Sorted", StringType, nullable = false)(),
+        AttributeReference("Sort Columns", StringType, nullable = true)())
 
 Review comment:
   2 problems here:
   1. if the `Sort Columns` is not `NA` here, will `Is Sorted` always be `true`? If so, I think we can only keep the `Sorted Columns` here.
   2. Since different segments can have different `sort_scope`, why do we discard the `sort scope` information here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services