[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3440: [CARBONDATA-3574] Block IUD for Add Segment and Delete segment by id issue fix

[GitBox]

xuchuanyin commented on a change in pull request #3440: [CARBONDATA-3574] Block IUD for Add Segment and Delete segment by id issue fix
URL: https://github.com/apache/carbondata/pull/3440#discussion_r345184619
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
 ##########
 @@ -102,6 +99,12 @@ private[sql] case class CarbonProjectForUpdateCommand(
         "update operation is not supported for index datamap")
     }
 
+    // If any other format segment exists then block the update operation
+    if (MixedFormatHandler.otherFormatSegmentsExist(carbonTable.getMetadataPath)) {
+      throw new AnalysisException(s"Unsupported update operation for table containing mixed " +
 
 Review comment:
   AnalysisException？
   suggest `MalformedCarbonCommandException` or `UnsupportedOperationException`，also this reflects that the exception in carbondata now is chaotic

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services