[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3440: [CARBONDATA-3574] Block IUD for Add Segment and Delete segment by id issue fix

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] xuchuanyin commented on a change in pull request #3440: [CARBONDATA-3574] Block IUD for Add Segment and Delete segment by id issue fix

GitBox
xuchuanyin commented on a change in pull request #3440: [CARBONDATA-3574] Block IUD for Add Segment and Delete segment by id issue fix
URL: https://github.com/apache/carbondata/pull/3440#discussion_r345196029
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForDeleteCommand.scala
 ##########
 @@ -68,6 +62,12 @@ private[sql] case class CarbonProjectForDeleteCommand(
       throw new MalformedCarbonCommandException("Unsupported operation on non transactional table")
     }
 
+    // If any other format segment exists then block the delete operation
+    if (MixedFormatHandler.otherFormatSegmentsExist(carbonTable.getMetadataPath)) {
+      throw new AnalysisException(s"Unsupported delete operation for table containing mixed " +
 
 Review comment:
   AnalysisException?
   suggest MalformedCarbonCommandException or UnsupportedOperationException

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services