[GitHub] [carbondata] xuchuanyin edited a comment on issue #3167: [CARBONDATA-3334] fixed multiple segment file issue for partition

[GitBox]

xuchuanyin edited a comment on issue #3167: [CARBONDATA-3334] fixed multiple segment file issue for partition
URL: https://github.com/apache/carbondata/pull/3167#issuecomment-479869158
 
 
   Feel like this modification is not elegant...
   The modification still confuse my even I've read the description of the PR...
   
   It is the MergeIndexWriter for partition loading that cause the problem, but you modify the loadModel instead. It seems that the writer and loadModel have some negotiations which makes the code complicated especially when the loadModel is at the beginning of loading while the MergeIndexWriter is at almost the end of loading.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services