[GitHub] [carbondata] zzcclp commented on a change in pull request #3157: [WIP] Added check for invalid tables in ShowCacheCommand

[GitBox]

zzcclp commented on a change in pull request #3157: [WIP] Added check for invalid tables in ShowCacheCommand
URL: https://github.com/apache/carbondata/pull/3157#discussion_r268046729
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/cache/CarbonShowCacheCommand.scala
 ##########
 @@ -74,6 +75,7 @@ case class CarbonShowCacheCommand(tableIdentifier: Option[TableIdentifier],
         .listAllTables(sparkSession).filter {
         carbonTable =>
           carbonTable.getDatabaseName.equalsIgnoreCase(currentDatabase) &&
+          isValidTable(carbonTable, sparkSession) &&
 
 Review comment:
   It's better use 'Checker.validateTableExists(databaseNameOp, tableName.get, sparkSession)'.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services