[GitHub] [carbondata] zzcclp commented on a change in pull request #3186: [CARBONDATA-3345]A growing streaming ROW_V1 carbondata file would be ingored some InputSplits

[GitBox]

zzcclp commented on a change in pull request #3186: [CARBONDATA-3345]A growing streaming ROW_V1 carbondata file would be ingored some InputSplits
URL: https://github.com/apache/carbondata/pull/3186#discussion_r278387790
 
 

 ##########
 File path: integration/presto/src/main/java/org/apache/carbondata/presto/impl/CarbonTableReader.java
 ##########
 @@ -291,7 +292,12 @@ private CarbonTableCacheModel getValidCacheBySchemaTableName(SchemaTableName sch
         // Use block distribution
         List<List<CarbonLocalInputSplit>> inputSplits = new ArrayList(
             result.stream().map(x -> (CarbonLocalInputSplit) x).collect(Collectors.groupingBy(
-                carbonInput -> carbonInput.getSegmentId().concat(carbonInput.getPath()))).values());
+                carbonInput -> {
+                  if (FileFormat.ROW_V1.equals(carbonInput.getFileFormat())){
+                    return carbonInput.getSegmentId().concat(carbonInput.getPath()).concat(carbonInput.getStart() + "");
 
 Review comment:
   why it needs to concat 'carbonInput.getStart()' when file format is ROW_V1?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services