[GitHub] [carbondata] zzcclp commented on a change in pull request #3258: [HOTFIX] fix none defaultValue for dateFormat and timestampFormat

[GitBox]

zzcclp commented on a change in pull request #3258: [HOTFIX] fix none defaultValue for dateFormat and timestampFormat
URL: https://github.com/apache/carbondata/pull/3258#discussion_r291093655
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/constants/CarbonLoadOptionConstants.java
 ##########
 @@ -71,7 +71,7 @@
   public static final String CARBON_OPTIONS_TIMESTAMPFORMAT =
           "carbon.options.timestamp.format";
 
-  public static final String CARBON_OPTIONS_TIMESTAMPFORMAT_DEFAULT = "";
+  public static final String CARBON_OPTIONS_TIMESTAMPFORMAT_DEFAULT = "yyyy-MM-dd HH:mm:ss";
 
 Review comment:
   It's better use CarbonCommonConstants.CARBON_TIMESTAMP_DEFAULT_FORMAT as default value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services