[GitHub] [carbondata] zzcclp commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon

[GitBox]

zzcclp commented on a change in pull request #3421: [CARBONDATA-3557] Support write Flink streaming data to Carbon
URL: https://github.com/apache/carbondata/pull/3421#discussion_r339382783
 
 

 ##########
 File path: core/src/main/java/org/apache/carbondata/core/indexstore/blockletindex/BlockDataMap.java
 ##########
 @@ -507,7 +509,7 @@ private void addTaskSummaryRowToUnsafeMemoryStore(CarbonRowSchema[] taskSummaryS
     if (null != summaryRow) {
       summaryRow.setByteArray(fileName, SUMMARY_INDEX_FILE_NAME);
       summaryRow.setByteArray(segmentId, SUMMARY_SEGMENTID);
-      if (null != filePath) {
+      if (filePath.length > 0) {
 
 Review comment:
   It better use:
   `null != filePath && filePath.length > 0`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services