[GitHub] [carbondata] zzcclp commented on a change in pull request #3443: [CARBONDATA-3561] Fix incorrect results after execute delete/update operation if there are null values

[GitBox]

zzcclp commented on a change in pull request #3443: [CARBONDATA-3561] Fix incorrect results after execute delete/update operation if there are null values
URL: https://github.com/apache/carbondata/pull/3443#discussion_r345554207
 
 

 ##########
 File path: datamap/examples/src/minmaxdatamap/main/java/org/apache/carbondata/datamap/examples/MinMaxIndexDataMapFactory.java
 ##########
 @@ -137,7 +137,7 @@ public DataMapBuilder createBuilder(Segment segment, String shardName,
    * @param segment
    */
   @Override
-  public void clear(Segment segment) {
+  public void clear(String segmentNo) {
 
 Review comment:
   These changes are not related to this  issue, just fix  some compile errors after PR#3434.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services