[GitHub] [carbondata] zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature

GitBox
zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature
URL: https://github.com/apache/carbondata/pull/3499#discussion_r355802953
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/createTable/TestCreateTableWithSortScope.scala
 ##########
 @@ -68,10 +68,10 @@ class TestCreateTableWithSortScope extends QueryTest with BeforeAndAfterAll {
          | stringField STRING
          | )
          | STORED BY 'carbondata'
-         | TBLPROPERTIES('SORT_COLUMNS'='stringField', 'SORT_SCOPE'='BATCH_SORT')
+         | TBLPROPERTIES('SORT_COLUMNS'='stringField', 'SORT_SCOPE'='local_sort')
 
 Review comment:
   please remove test case about table 'tableWithBatchSort':
   line 32: `sql("DROP TABLE IF EXISTS tableWithBatchSort")`
   and the code from line 64.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services