[GitHub] [carbondata] zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature

[GitBox]

zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature
URL: https://github.com/apache/carbondata/pull/3499#discussion_r355804251
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/sortcolumns/TestSortColumns.scala
 ##########
 @@ -447,7 +447,7 @@ class TestSortColumns extends QueryTest with BeforeAndAfterAll {
   def setLoadingProperties(offheap: String, unsafe: String, useBatch: String): Unit = {
     CarbonProperties.getInstance().addProperty(CarbonCommonConstants.ENABLE_OFFHEAP_SORT, offheap)
     if (useBatch.equalsIgnoreCase("true")) {
 
 Review comment:
   use `unsafe.equalsIgnoreCase("true")` instead of `useBatch.equalsIgnoreCase("true")`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services