[GitHub] [carbondata] zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature

GitBox
zzcclp commented on a change in pull request #3499: [CARBONDATA-3607] Remove batch_sort feature
URL: https://github.com/apache/carbondata/pull/3499#discussion_r355804754
 
 

 ##########
 File path: integration/spark-common-test/src/test/scala/org/apache/carbondata/spark/testsuite/standardpartition/StandardPartitionGlobalSortTestCase.scala
 ##########
 @@ -948,7 +948,7 @@ class StandardPartitionGlobalSortTestCase extends QueryTest with BeforeAndAfterA
         |  projectcode int, projectenddate Timestamp,attendance int,
         |  utilization int, doj Timestamp, empname String)
         | PARTITIONED BY (projectjoindate Timestamp, salary decimal)
-        | STORED BY 'org.apache.carbondata.format' TBLPROPERTIES('SORT_SCOPE'='BATCH_SORT')
+        | STORED BY 'org.apache.carbondata.format' TBLPROPERTIES('SORT_SCOPE'='local_sort')
       """.stripMargin)
     sql(s"""LOAD DATA local inpath '$resourcesPath/data.csv' INTO TABLE partitiondefaultbatchsort OPTIONS('DELIMITER'= ',', 'QUOTECHAR'= '"')""")
     checkAnswer(sql("select count(*) from partitiondefaultbatchsort"), Seq(Row(10)))
 
 Review comment:
   rename 'partitiondefaultbatchsort' to 'partitiondefaultlocalsort'

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services