[GitHub] [carbondata] zzcclp commented on a change in pull request #3504: [WIP] [CARBONDATA-3614] Support Alter table properties set/unset for longstring columns

[GitBox]

zzcclp commented on a change in pull request #3504: [WIP] [CARBONDATA-3614] Support Alter table properties set/unset for longstring columns
URL: https://github.com/apache/carbondata/pull/3504#discussion_r355916771
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/util/AlterTableUtil.scala
 ##########
 @@ -172,6 +172,32 @@ object AlterTableUtil {
     }
   }
 
+  /**
+   * update schema when LONG_STRING_COLUMNS are changed
+   */
+  private def updateSchemaForLongStringColumns(
+      thriftTable: TableInfo,
+      longStringColumns: String,
+      schemaConverter: SchemaConverter
+  ) = {
+    val columns = thriftTable.getFact_table.getTable_columns.asScala
 
 Review comment:
   Long string columns will be moved after dimension columns and before complex columns internally, it better resort here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services