zzcclp commented on a change in pull request #3507: [CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…
URL:
https://github.com/apache/carbondata/pull/3507#discussion_r356991870
##########
File path: core/src/main/java/org/apache/carbondata/core/datastore/row/CarbonRow.java
##########
@@ -49,6 +49,14 @@ public CarbonRow(Object[] data, Object[] rawData) {
return data;
}
+ public Object[] getKey(int[] sortColumnIndex) {
+ Object[] key = new Object[sortColumnIndex.length];
Review comment:
I agree with @ajantha-bhat , sortBy will call keyBy first, and keyBy uses map method to generate a (key, value) tuple, with above way, it will copy a key object array for every row. GC time will be reduced in this way? @marchpure, can you test some cases and show performance report ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[hidden email]
With regards,
Apache Git Services
Locked
