[GitHub] [carbondata] zzcclp commented on a change in pull request #3507: [CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…

[GitBox]

zzcclp commented on a change in pull request #3507: [CARBONDATA-3617] loadDataUsingGlobalSort should based on SortColumns…
URL: https://github.com/apache/carbondata/pull/3507#discussion_r357053276
 
 

 ##########
 File path: integration/spark-common/src/main/scala/org/apache/carbondata/spark/load/DataLoadProcessBuilderOnSpark.scala
 ##########
 @@ -121,9 +121,12 @@ object DataLoadProcessBuilderOnSpark {
         CarbonProperties.getInstance().getGlobalSortRddStorageLevel()))
     }
 
+    val sortColumnIndex = configuration.getSortColumnRangeInfo.getSortColumnIndex
 
 Review comment:
   don't use configuration.getSortColumnRangeInfo.getSortColumnIndex, when sort_scope is global sort, configuration.getSortColumnRangeInfo is null.
   Use:
   `val numberOfSortColumns = configuration.getNumberOfSortColumns`,
   and change CarbonRow.getKey(int[] sortColumnIndex) to getKey(int numberOfSortColumn).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services