[GitHub] [carbondata] zzcclp commented on a change in pull request #3509: [CARBONDATA-3618] Update query should throw exception if key has more than one value

[GitBox]

zzcclp commented on a change in pull request #3509: [CARBONDATA-3618] Update query should throw exception if key has more than one value
URL: https://github.com/apache/carbondata/pull/3509#discussion_r358031633
 
 

 ##########
 File path: integration/spark2/src/main/scala/org/apache/spark/sql/execution/command/mutation/CarbonProjectForUpdateCommand.scala
 ##########
 @@ -135,7 +136,22 @@ private[sql] case class CarbonProjectForUpdateCommand(
           else {
             Dataset.ofRows(sparkSession, plan)
           }
-
+          // If more than one value present for the update key, should fail the update
+          val ds = dataSet.select(CarbonCommonConstants.CARBON_IMPLICIT_COLUMN_TUPLEID)
 
 Review comment:
   yeah, I know that, but I still worry about the update performance when update huge data, even though just filter only tupleID column, but it still do 'group by' operation.
   The way I mentioned above just needs to do a 'count' operation, and it can check this in earlier step.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services