[GitHub] [carbondata] zzcclp opened a new pull request #3443: [CARBONDATA-3561] Fix incorrect results after execute delete/update operation if there are null values

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] [carbondata] zzcclp opened a new pull request #3443: [CARBONDATA-3561] Fix incorrect results after execute delete/update operation if there are null values

GitBox
zzcclp opened a new pull request #3443: [CARBONDATA-3561] Fix incorrect results after execute delete/update operation if there are null values
URL: https://github.com/apache/carbondata/pull/3443
 
 
   **Problem:**
   If there are null values in table, after execute delete/update sql, the results are incorrect when query with vector mode
   
   **Root cause:**
   In method 'fillVector' of 'LocalDictDimensionDataChunkStore', if the type of 'vector' is 'ColumnarVectorWrapperDirectWithDeleteDelta', the parameter 'counter' of 'ColumnarVectorWrapperDirectWithDeleteDelta' does not increase when the data is not null, so it will set the null value to the wrong index.
   
   **Solution:**
   Increase 'counter' of 'ColumnarVectorWrapperDirectWithDeleteDelta' when the data is not null.
   
   Be sure to do all of the following checklist to help us incorporate
   your contribution quickly and easily:
   
    - [ ] Any interfaces changed?  No
   
    - [ ] Any backward compatibility impacted?  No
   
    - [ ] Document update required?  No
   
    - [ ] Testing done
           Please provide details on
           - Whether new unit test cases have been added or why no new tests are required?
           - How it is tested? Please attach test report.
           - Is it a performance related change? Please attach the performance test report.
           - Any additional information to help reviewers in testing this change.
         
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[hidden email]


With regards,
Apache Git Services