[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

qiuchenjian-2
Github user lion-x commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/310#discussion_r89580862
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/metadata/schema/table/CarbonTable.java ---
    @@ -62,6 +62,11 @@
       private Map<String, List<CarbonDimension>> tableDimensionsMap;
     
       /**
    +   * TableName, Dimensions and children dimensions list
    +   */
    +  private Map<String, List<CarbonDimension>> tableAllDimensionsMap;
    +
    +  /**
        * table measures list.
    --- End diff --
   
    what's the different between tableDimensionsMap and tableAllDimensionsMap, can merge them into one ?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---