[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #310: [CARBONDATA-401] One Pass Load

qiuchenjian-2
Github user foryou2030 commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/310#discussion_r92959768
 
    --- Diff: core/src/main/java/org/apache/carbondata/core/carbon/metadata/schema/table/CarbonTable.java ---
    @@ -504,4 +521,19 @@ public void setBlockSizeInMB(int blockSize) {
         this.blockSize = blockSize;
       }
     
    +  /**
    +   * to get the all dimension of a table
    +   *
    +   * @param tableName
    +   * @return all dimension of a table
    +   */
    +  public CarbonDimension getAllDimensionByName(String tableName, String columnName) {
    --- End diff --
   
    it is used to get normal dimension and the primitive dimenson of the complex.
    I will rename it to a proper name


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---