[GitHub] incubator-carbondata pull request #324: [CARBONDATA-420] Remove unused param...

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[GitHub] incubator-carbondata pull request #324: [CARBONDATA-420] Remove unused param...

qiuchenjian-2
Github user jackylk commented on a diff in the pull request:

    https://github.com/apache/incubator-carbondata/pull/324#discussion_r88768124
 
    --- Diff: conf/carbon.properties.template ---
    @@ -52,7 +52,7 @@ carbon.compaction.level.threshold=4,3
     #default size (in MB) for major compaction to be triggered
     carbon.major.compaction.size=1024
     ######## Query Configuration ########
    -#Number of cores to be used while querying
    +#Number of cores to be used for loading blocks when execute query
    --- End diff --
   
    It is not just for query, compaction also need this parameter.
    I think a better description is "Number of cores to be used for loading index into memory"


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---