[GitHub] incubator-carbondata pull request #331: Carbondata 396

[qiuchenjian-2]

GitHub user harmeetsingh0013 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/331

    Carbondata 396

    Write unit test cases for org.apache.carbondata.core.datastorage.store.columnar.BlockIndexerStorageForInt.java and org.apache.carbondata.core.datastorage.store.columnar.UnBlockIndexer.java

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/harmeetsingh0013/incubator-carbondata CARBONDATA-396

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/331.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #331
   
----
commit 3a80545dc7b7f22839386bb1a01f31f6570512bd
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-11-16T11:49:03Z

    Add unit test cases for ColumnDictionaryInfo class

commit fd7591f45ac1d7eb9fea55813b94882de301e6fa
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-11-17T07:32:05Z

    Add unit test cases for ColumnDictionaryInfo class

commit 980096ae8a26dca25d2bf8461c4eb4e63b28682f
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-11-17T10:53:50Z

    Add unit test cases for ColumnDictionaryInfo class

commit 90e229cab2d0d73e8c840cc899ce06bf0d73b5be
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-11-18T08:08:39Z

    Add unit test cases for BlockIndexerStorageForInt.java and UnBlockIndexer

commit 9ea2af37326a2ca33da54f4970b97bd04c18921d
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-11-18T10:04:49Z

    Add variables for expected results in unit test

commit e46c80914c619c8edd0ca15869ce15b06be08d86
Author: harmeetsingh0013 <[hidden email]>
Date:   2016-11-18T10:23:17Z

    Remove unit test file of CARBONDATA-371 issue

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    Hello, @ravipesala please review this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    Can one of the admins verify this patch?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    yes @ravipesala , Is there any problem?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    @harmeetsingh0013  Please correct the PR title correctly.
    It supposed to be [CARBONDATA-396], please correct for all your PRs


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/79/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    @harmeetsingh0013 It seems I could not rebase it because of conflicts in some of your commit.
    Please squash all commits to 1 commit.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/118/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
     @ravipesala i commit the new changes and need to run CI.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user CarbonDataQA commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    Build Success with Spark 1.5.2, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder/144/



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user jackylk commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/331
 
    Hi @jackylk , at my end, the build create successfully. I am not sure, what is the problem CI, because according to dependencies, the problem with downloading dependencies.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user harmeetsingh0013 closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/331


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---