[GitHub] incubator-carbondata pull request #340: [Carbondata 434] Improved integratio...

[qiuchenjian-2]

GitHub user anubhav100 opened a pull request:

    https://github.com/apache/incubator-carbondata/pull/340

    [Carbondata 434] Improved integration test cases for AllDataTypesTestCase2

   

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anubhav100/incubator-carbondata CARBONDATA-434

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-carbondata/pull/340.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #340
   
----
commit 8c7de7b27d604981279a1901674fcba56123bc87
Author: anubhav100 <[hidden email]>
Date:   2016-11-22T06:56:42Z

    improved integration test cases for alldatatypecheckcase2

commit c00ca9931e0a57e80d46f46f1081339e9db9142b
Author: anubhav100 <[hidden email]>
Date:   2016-11-22T07:08:35Z

    removed unnecessary parenthests from AllDataTypesTestCase2

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/340
 
    @ravipesala i removed duplicate test cases from AllDataTypeCase2 please have a look


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/340
 
    Please rebase the code, don't let other commits come to this PR.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user anubhav100 commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/340
 
    @ravipesala i rebased the code and there is one correction becuase of which your build of integration test case will be failing here return keyword is missing in query test:  |$e
                   |${org.apache.spark.sql.catalyst.util.stackTraceToString(e)}
                """.stripMargin
     -        Some(errorMessage)
     +       return Some(errorMessage)
          }
     
          if (prepareAnswer(expectedAnswer) != prepareAnswer(sparkAnswer)) {
     @@ -157,7 +157,7 @@ object QueryTest {
                    prepareAnswer(sparkAnswer).map(_.toString())).mkString("\n")
              }
            """.stripMargin
     -      Some(errorMessage)
     +      return Some(errorMessage)
          } i corrected this in this pr first you need to merge this pr before merging other pr for integration test cases otherwise there will be compilation errors


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user ravipesala commented on the issue:

    https://github.com/apache/incubator-carbondata/pull/340
 
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---

[qiuchenjian-2]

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-carbondata/pull/340


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [hidden email] or file a JIRA ticket
with INFRA.
---